dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

ci: add multi-platform image build for karmada-dashboard

Open warjiang opened this issue 11 months ago • 4 comments

What type of PR is this? /kind feature

What this PR does / why we need it: add multi platforms build because some users need arm64 image => https://github.com/karmada-io/dashboard/issues/164

and we have plan to add support for arm64: https://github.com/karmada-io/dashboard/issues/121

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

warjiang avatar Jan 21 '25 02:01 warjiang

/assign @RainbowMango @samzong

warjiang avatar Jan 21 '25 02:01 warjiang

@RainbowMango What do u think?

/lgtm

samzong avatar Jan 21 '25 07:01 samzong

I will take a look, maybe we can borrow some idea from karmada-io/karmada repo.

RainbowMango avatar Jan 21 '25 07:01 RainbowMango

@RainbowMango Are you still working on this?

samzong avatar May 09 '25 09:05 samzong

Thanks for the reminder, I totally forgot this. Will take a look next week.

RainbowMango avatar May 09 '25 11:05 RainbowMango

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar May 12 '25 01:05 karmada-bot

@warjiang Could you please check the failing tests on master?

https://github.com/karmada-io/dashboard/actions/runs/14962016539/job/42025429251

> @karmada/[email protected] build /home/runner/work/dashboard/dashboard/ui/apps/dashboard
> tsc && vite build

Error: src/components/panel/index.tsx(67,38): error TS2322: Type 'MenuItem[]' is not assignable to type 'Partial<BreadcrumbItemType & BreadcrumbSeparatorType>[]'.
  Type 'MenuItem' is not assignable to type 'Partial<BreadcrumbItemType & BreadcrumbSeparatorType>'.
    Index signature for type '`data-${string}`' is missing in type 'MenuItem'.
 ELIFECYCLE  Command failed with exit code 2.
Error: @karmada/dashboard#build: command (/home/runner/work/dashboard/dashboard/ui/apps/dashboard) /home/runner/setup-pnpm/node_modules/.bin/pnpm run build exited (2)
Error:  command finished with error: command (/home/runner/work/dashboard/dashboard/ui/apps/dashboard) /home/runner/setup-pnpm/node_modules/.bin/pnpm run build exited (2)

 Tasks:    2 successful, 3 total
Cached:    0 cached, 3 total
  Time:    7.529s 
Failed:    @karmada/dashboard#build

RainbowMango avatar May 12 '25 01:05 RainbowMango

@warjiang Could you please check the failing tests on master?

https://github.com/karmada-io/dashboard/actions/runs/14962016539/job/42025429251


> @karmada/[email protected] build /home/runner/work/dashboard/dashboard/ui/apps/dashboard

> tsc && vite build



Error: src/components/panel/index.tsx(67,38): error TS2322: Type 'MenuItem[]' is not assignable to type 'Partial<BreadcrumbItemType & BreadcrumbSeparatorType>[]'.

  Type 'MenuItem' is not assignable to type 'Partial<BreadcrumbItemType & BreadcrumbSeparatorType>'.

    Index signature for type '`data-${string}`' is missing in type 'MenuItem'.

 ELIFECYCLE  Command failed with exit code 2.

Error: @karmada/dashboard#build: command (/home/runner/work/dashboard/dashboard/ui/apps/dashboard) /home/runner/setup-pnpm/node_modules/.bin/pnpm run build exited (2)

Error:  command finished with error: command (/home/runner/work/dashboard/dashboard/ui/apps/dashboard) /home/runner/setup-pnpm/node_modules/.bin/pnpm run build exited (2)



 Tasks:    2 successful, 3 total

Cached:    0 cached, 3 total

  Time:    7.529s 

Failed:    @karmada/dashboard#build

ok, I'll check it later today

warjiang avatar May 12 '25 01:05 warjiang

@RainbowMango For the failed ci job, it's the problem of outdated ci workflow file, link of failed job => https://github.com/karmada-io/dashboard/actions/runs/14962016539/job/42025429251 and the corresponding workflow file => https://github.com/karmada-io/dashboard/actions/runs/14962016539/workflow

for the ci workflow in the main branch, the difference is image

we've already update the build-frontend job in the ci.yml file, but the ci still running with the outdated ci.yml, I think for the next time, the ci will work as expected.

warjiang avatar May 12 '25 03:05 warjiang

i have some cleanup to do, maybe i can re-test the failed ci job in another PR

warjiang avatar May 12 '25 03:05 warjiang