dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

Add sentry for monitor

Open warjiang opened this issue 1 year ago • 7 comments

What type of PR is this? /kind feature

What this PR does / why we need it: Karmada-dashboard will be used in our end-users clusters, sometimes end-users will meet problems like crash of web-ui、system errors, for a better experience of detect bug and help end-users to solve problems quickly, we need to introduce monitor system help us capture exception stacktrace.

Which issue(s) this PR fixes: Fixes #122

Special notes for your reviewer:

  • we need to set SENTRY_AUTH_TOKEN but lack of permission

Does this PR introduce a user-facing change?:

NONE

warjiang avatar Nov 13 '24 03:11 warjiang

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from warjiang. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Nov 13 '24 03:11 karmada-bot

we need to set SENTRY_AUTH_TOKEN but lack of permission

I think we can talk about it at today's meeting.

RainbowMango avatar Nov 13 '24 03:11 RainbowMango

we need to set SENTRY_AUTH_TOKEN but lack of permission

I think we can talk about it at today's meeting.

ok~

warjiang avatar Nov 13 '24 04:11 warjiang

Hi, I added the secret with the name SENTRY_AUTH_TOKEN.

RainbowMango avatar Nov 13 '24 07:11 RainbowMango

Hi @warjiang does PR ready for moving forward?

RainbowMango avatar Dec 31 '24 01:12 RainbowMango

Hi @warjiang does PR ready for moving forward?

Need an extra switch to enable or disable monitor.

warjiang avatar Dec 31 '24 02:12 warjiang

Is it planned in this PR or a separate one?

RainbowMango avatar Dec 31 '24 03:12 RainbowMango