karma icon indicating copy to clipboard operation
karma copied to clipboard

Critical vulnerability: Insufficient validation when decoding a Socket.IO packet

Open salomedo opened this issue 1 year ago • 10 comments

Hello,

We are currently facing a critical vulnerability in our project that depends on karma. https://github.com/advisories/GHSA-qm95-pgcg-qqfq

Steps to reproduce: npm install npm audit

Console message:

├─ socket.io-parser: 4.0.4                                                                                                                                 
│  ├─ Issue: Insufficient validation when decoding a Socket.IO packet                                                                                      
│  ├─ URL: https://github.com/advisories/GHSA-qm95-pgcg-qqfq                                                                                               
│  ├─ Severity: critical                                                                                                                                   
│  ├─ Vulnerable Versions:                                                                                                                           
│  ├─ Patched Versions: >=4.0.5                                                                                                                            
│  ├─ Via: karma, karma-htmlfile-reporter, karma-jasmine-html-reporter                                                                                     
│  └─ Recommendation: Upgrade to version 4.0.5 or later   

Thank you in advance.

salomedo avatar Oct 31 '22 16:10 salomedo

yeah experienced the same thing.

johnbumgardner avatar Nov 01 '22 12:11 johnbumgardner

I've tried updating my Karma stack to 6.4.1 but a few of my Karma suites are halting/failing to complete. When I view in the browser, I see pending localhost/socket-io requests that never complete, they just restart after 30 seconds. Feels awfully related to either this dependency or socket.io-parser.

image

dep avatar Nov 01 '22 21:11 dep

I've tried updating my Karma stack to 6.4.1 but a few of my Karma suites are halting/failing to complete. When I view in the browser, I see pending localhost/socket-io requests that never complete, they just restart after 30 seconds. Feels awfully related to either this dependency or socket.io-parser.

image

6.4.1 is using the vulnerable socket.io

i made a PR bumping it and waiting on it to get reviewed.

#3825

johnbumgardner avatar Nov 02 '22 02:11 johnbumgardner

I tried adding these two resolutions along with 6.4.1 but ran into the same problem.

"resolutions": {
    ...
    "**/socket.io": "4.5.2",
    "**/socket.io-parser": "4.2.1",
    ...
}

dep avatar Nov 02 '22 12:11 dep

I'm experiencing the same problem

amanyzohair avatar Nov 06 '22 14:11 amanyzohair

Any timeline on getting this PR merged?

dep avatar Nov 07 '22 16:11 dep

+1, waiting for the patch version...

AllForNothing avatar Nov 17 '22 03:11 AllForNothing

+1, waiting for the patch version...

LucasLopesr avatar Nov 29 '22 19:11 LucasLopesr

+1, we are also waiting for the patch version...

efogarasi avatar Nov 30 '22 08:11 efogarasi

+1, waiting for the patch version...

amanyzohair avatar Dec 11 '22 09:12 amanyzohair