karma icon indicating copy to clipboard operation
karma copied to clipboard

[Infra]: Update commitlint configuration to allow for longer commit headers

Open devversion opened this issue 4 years ago • 2 comments

This is a tracking issue which should open the discussion for expanding the maximum header length to something greater which allows for more comprehensive commit headers. The current limit seems very high, given the default of @commitlint/config-angular being set to 72 characters:

https://github.com/conventional-changelog/commitlint/blob/ea523613e4099c182212feec96f2b702f97fa100/%40commitlint/config-angular/index.js#L9

The current config can be updated by overriding the default rule value from the preset using: https://github.com/conventional-changelog/commitlint/blob/master/docs/reference-rules.md.

devversion avatar Nov 02 '21 17:11 devversion

@devoto13 WDYT?

jginsburgn avatar Nov 02 '21 19:11 jginsburgn

I'm fine setting it to any reasonably high value or disabling the rule altogether. I don't know why commitlint has such a default. One nice-to-have from my side would be for the limit to be smaller than the GitHub's PR title limit, so the whole commit header fits into the title and is not wrapped into PR description, but it's just nice-to-have, could totally live without it.

Don't forget to update docs when changing the value.

devoto13 avatar Nov 02 '21 20:11 devoto13