karma
karma copied to clipboard
fix(web-server): ignore future socket errors
Karma sometimes reports uncaught exceptions (ECONNRESET) which causes it to exit the process with a non-zero exit code.
Fixes #3295
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
:white_check_mark: Build karma 62 completed (commit https://github.com/karma-runner/karma/commit/6b00be646c by @mgroenhoff)
:white_check_mark: Build karma 2460 completed (commit https://github.com/karma-runner/karma/commit/6b00be646c by @mgroenhoff)
@googlebot I signed it!
:white_check_mark: Build karma 61 completed (commit https://github.com/karma-runner/karma/commit/6b00be646c by @mgroenhoff)
:white_check_mark: Build karma 2783 completed (commit https://github.com/karma-runner/karma/commit/8f39f90852 by @mgroenhoff)
:white_check_mark: Build karma 386 completed (commit https://github.com/karma-runner/karma/commit/8f39f90852 by @mgroenhoff)
:white_check_mark: Build karma 385 completed (commit https://github.com/karma-runner/karma/commit/8f39f90852 by @mgroenhoff)
Any update on this? Is anyone who knows the code willing to do the required review?
I reviewed but never received updates.
@mgroenhoff do we still need to merge this PR?