karma icon indicating copy to clipboard operation
karma copied to clipboard

fix(web-server): ignore future socket errors

Open mgroenhoff opened this issue 4 years ago • 12 comments

Karma sometimes reports uncaught exceptions (ECONNRESET) which causes it to exit the process with a non-zero exit code.

Fixes #3295

mgroenhoff avatar Dec 17 '19 13:12 mgroenhoff

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Dec 17 '19 13:12 googlebot

:white_check_mark: Build karma 62 completed (commit https://github.com/karma-runner/karma/commit/6b00be646c by @mgroenhoff)

karmarunnerbot avatar Dec 17 '19 13:12 karmarunnerbot

:white_check_mark: Build karma 2460 completed (commit https://github.com/karma-runner/karma/commit/6b00be646c by @mgroenhoff)

AppVeyorBot avatar Dec 17 '19 13:12 AppVeyorBot

@googlebot I signed it!

mgroenhoff avatar Dec 17 '19 13:12 mgroenhoff

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Dec 17 '19 13:12 googlebot

:white_check_mark: Build karma 61 completed (commit https://github.com/karma-runner/karma/commit/6b00be646c by @mgroenhoff)

karmarunnerbot avatar Dec 17 '19 13:12 karmarunnerbot

:white_check_mark: Build karma 2783 completed (commit https://github.com/karma-runner/karma/commit/8f39f90852 by @mgroenhoff)

AppVeyorBot avatar Nov 26 '20 01:11 AppVeyorBot

:white_check_mark: Build karma 386 completed (commit https://github.com/karma-runner/karma/commit/8f39f90852 by @mgroenhoff)

karmarunnerbot avatar Nov 26 '20 01:11 karmarunnerbot

:white_check_mark: Build karma 385 completed (commit https://github.com/karma-runner/karma/commit/8f39f90852 by @mgroenhoff)

karmarunnerbot avatar Nov 26 '20 01:11 karmarunnerbot

Any update on this? Is anyone who knows the code willing to do the required review?

costescuandrei avatar Apr 08 '21 13:04 costescuandrei

I reviewed but never received updates.

johnjbarton avatar Apr 08 '21 21:04 johnjbarton

@mgroenhoff do we still need to merge this PR?

jginsburgn avatar May 12 '21 01:05 jginsburgn