karma-ng-scenario icon indicating copy to clipboard operation
karma-ng-scenario copied to clipboard

Use strict DI for $delegate and $browser

Open Chris380 opened this issue 9 years ago • 3 comments

Without this change I ran into a error testing an app with strict DI activated: Error: [$injector:strictdi] function($delegate) is not using explicit annotation and can not be invoked in strict mode http://errors.angularjs.org/1.4.6/$injector/strictdi?p0=function(%24delegate)

Chris380 avatar Sep 24 '15 06:09 Chris380

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar Sep 24 '15 06:09 googlebot

2 things prevent me from merging this.

  1. Googlebot.
  2. angular-scenario is just copy/pasted compiled code here, and if/when we ever upgrade to newer versions of ng-scenario this change will have to go along with it, so I'd imagine the right place to put this PR would be in https://github.com/angular/angular.js/tree/master/src/ngScenario

vkarpov15 avatar Sep 25 '15 20:09 vkarpov15

One alternative to this might be to use something like ng-annotate to transform the library at build time, to be able to enable strict DI.

davidparsson avatar Feb 24 '16 20:02 davidparsson