karma-ng-scenario
karma-ng-scenario copied to clipboard
Use strict DI for $delegate and $browser
Without this change I ran into a error testing an app with strict DI activated: Error: [$injector:strictdi] function($delegate) is not using explicit annotation and can not be invoked in strict mode http://errors.angularjs.org/1.4.6/$injector/strictdi?p0=function(%24delegate)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
- If you signed the CLA as a corporation, please let us know the company's name.
2 things prevent me from merging this.
- Googlebot.
- angular-scenario is just copy/pasted compiled code here, and if/when we ever upgrade to newer versions of ng-scenario this change will have to go along with it, so I'd imagine the right place to put this PR would be in https://github.com/angular/angular.js/tree/master/src/ngScenario
One alternative to this might be to use something like ng-annotate to transform the library at build time, to be able to enable strict DI.