karma-ng-html2js-preprocessor icon indicating copy to clipboard operation
karma-ng-html2js-preprocessor copied to clipboard

Fixed example configuration to not use non-existing String.strip.

Open burka opened this issue 8 years ago • 3 comments

filepath.strip is not a function, so I would replace it with replace. See #90

burka avatar Jun 08 '16 13:06 burka

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar Jun 08 '16 13:06 googlebot

I signed it!

burka avatar Jun 08 '16 13:06 burka

CLAs look good, thanks!

googlebot avatar Jun 08 '16 13:06 googlebot