karma-ng-html2js-preprocessor icon indicating copy to clipboard operation
karma-ng-html2js-preprocessor copied to clipboard

Added optional support for systemJS

Open Kiachma opened this issue 9 years ago • 4 comments

Tried wrapping my head around the coffescript tests, but couldn't come up with anything useful. Help appreciated =)

Kiachma avatar Jul 02 '15 14:07 Kiachma

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar Jul 02 '15 14:07 googlebot

I signed it!

Kiachma avatar Jul 02 '15 14:07 Kiachma

CLAs look good, thanks!

googlebot avatar Jul 02 '15 14:07 googlebot

Thanks for your contribution, for a test, about something like this:

it 'should process systemjs imports', (done) ->
  process = createPreprocessor systemJS: true
  file = new File '/base/path/file.html'

  process 'my content', file, (processedContent) ->
    expect(processedContent).to.equal """
      import angular from "angular";
      my content
      """
    done()

dignifiedquire avatar Jul 08 '15 21:07 dignifiedquire