karma-mocha icon indicating copy to clipboard operation
karma-mocha copied to clipboard

Don't use the root property to determine suite root.

Open lddubeau opened this issue 7 years ago • 3 comments

The root property is problematic because Mocha sets it true if the description of a suite is the empty string. However, Mocha runs perfectly well with suites that have empty names. See:

https://github.com/mochajs/mocha/issues/2755

Instead of relying on the root property, rely on whether the parent property is set. If not, then we are at the root.

lddubeau avatar Oct 05 '17 14:10 lddubeau

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

googlebot avatar Oct 05 '17 14:10 googlebot

I signed the CLA.

The failing tests are not due to the changes I made but to a misconfiguration of the Travis parameters (which I did not touch).

lddubeau avatar Oct 05 '17 14:10 lddubeau

CLAs look good, thanks!

googlebot avatar Oct 05 '17 14:10 googlebot