karma-firefox-launcher icon indicating copy to clipboard operation
karma-firefox-launcher copied to clipboard

Add Profile Choice Functionality To The Module

Open barakhaim opened this issue 10 years ago • 5 comments

Added the option to mimic "firefox.exe -p ". When adding "customProfile" to the "customLauncher" firefox will launch said profile. The profiles list is shown when you execute "firefox.exe -p". This was added as a solution to karma-runner/karma-firefox-launcher issue #46 . Example:

browsers: ['FirefoxWithMyExtension'],

customLaunchers: { FirefoxWithMyExtension: { base: 'Firefox', customProfile: 'Karma', extensions: [ path.resolve(__dirname, '../[email protected]'), ] }}

This will upload the "karma" firefox i've setup beforehand using "firefox.exe -p", in it, my configs, such as imported certs.

Ignoring this field will save the exact API of the original.

barakhaim avatar Jan 13 '16 08:01 barakhaim

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar Jan 13 '16 08:01 googlebot

Can you add some documentation on how to use this to the Readme as well please?

dignifiedquire avatar Jan 13 '16 10:01 dignifiedquire

Sure, I just pushed it.

barakhaim avatar Jan 13 '16 10:01 barakhaim

+1

sechel avatar Mar 01 '16 12:03 sechel

@barakhaim one style issue and after that please squash all commits into one (git rebase -i)

dignifiedquire avatar Mar 01 '16 13:03 dignifiedquire

For what it's worth, I rebased this over on the custom-profile branch but I don't understand if it's still needed. It looks like we now have the profile argument which allows specifying the path to an existing profile. Do we also need to be able to specify a profile by name?

birtles avatar Oct 19 '22 00:10 birtles

Too old, closing, feel free to reopen is still relevant!

pmvald avatar Mar 03 '24 23:03 pmvald