Karl Stolley
Karl Stolley
Okay. Please see my comments above. Also, make your screenshots way more simple to compare as before and after. The best ways to do this: 1. Make sure you have...
You've still not addressed all of the feedback I've left. And it doesn't make sense to have one commit that says a specific area for where the `@` symbol has...
A commit that says "everywhere" is still misleading. It's not "everywhere." Please be precise in your wording and your work, and imagine a time where some future contributor might need...
Left some comments, including on the CSS. I've poked at this in development, and while I don't think this will be a high-impact change for long-term or power users, I...
On the whole some good work here, @kehshiba, but seem my comments above. You'll also need to tidy up your commit history and follow our style outlined in https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html
That commit is necessary for the overall grid alignment in the message box. What I think needs to be applied here are the styles introduced in #26942 to the `&:has(>...
If there's any text at all, that could give you a false negative. Test with just the image by itself, without any text. Your selector looks good to me, but...
Getting the icon alignment right here is going to take some doing. Containers like `.above_compose_banner_action_link` should probably be set to `display: inline-flex`, but then there is other stuff going on...
Okay. I gave this another read-through and it looks good. Likewise in one final round of manual testing. Marking for integration review. Thanks, @PieterCK!
@sahil839 said: > Changes look good. The first two suggestions in the PR description also seems good. > > I do not get the third one. I guess currently the...