Karl Stolley

Results 58 comments of Karl Stolley

All right. Please re-create all of your screenshots with the original PR above. The very first one I checked is all wrong: ![Screenshot 2024-04-02 at 2 33 23 PM](https://github.com/zulip/zulip/assets/170719/494227ca-d1f6-4b9e-9a30-91d487567437)

Ah, that's right. Okay, so how about this plan: your `copy_to_clipboard_svg.hbs` should get the `` portion of this in its pure form, with any additional variables (IDs, classes) passable as...

Something is not right. I'm still seeing this on Firefox/Mac: ![Screenshot 2024-05-01 at 2 33 22 PM](https://github.com/zulip/zulip/assets/170719/380c1cc9-2c1c-415b-9a09-37121c8d48a2) And Chrome/Mac: ![Screenshot 2024-05-01 at 2 34 02 PM](https://github.com/zulip/zulip/assets/170719/21e3a290-701b-499c-a8b7-b0968306a167)

These colors and other values should be expressed as CSS variables; let's not go the route of adding more lines to `dark_theme.css`. To do this, you'll likely need to make...

> @karlstolley If that's the case for the table border color, shouldn't the other parts of the table also be refactored in the same way? The obvious one I noticed...

A few code-organization nits. I'm not certain we won't see some regressions from striking those table-oriented element selectors in dark mode, but the fixes for those would be to use...

This looks like a reasonable set of changes to me, minus one little nit about a variable name.

@alya yes, I'll tackle this one tomorrow (January 25)

@ecxtacy have you updated screenshots since adjusting where the bot icon sits relative to the text? The screenshots as presented do show quite a bit of variation. In terms of...

@ecxtacy can you resolved the merge conflicts here and @-message me so I can do another review pass on this?