Karl Stolley
Karl Stolley
@muziejus & @elotroalex cool. I'm karl.stolley on Skype -- I realized this morning I have another meeting at 12:45pm CT/1:45pm ET so I'm a little boxed-in for time. But hopefully...
FYI I updated the version roadmap to include items from your list, @muziejus -- https://github.com/minicomp/ed/wiki/Version-Roadmap#20x
@alya said: > Cool! Most of the changes seem good or neutral to me (just visually comparing the screenshots). The two where it seems like there's two much space now...
Okay. So what I've elected to do here is just normalize the `margin-bottom` across the two outlier elements that didn't already have a 5px value: `p` (which had been 3px)...
Overall this LGTM. It would be nice to clean up the underscore-style classes and replace them with hyphenated versions as a prep commit.
Those hyphenation prep changes look good, but the commit message should probably be prefixed with "profile_modal" or something more specific than "css," as the message as written doesn't make it...
Commit message looks good, but as a *prep* commit, that should be your first commit, so that the substantive changes here already have the hyphenated class. `git rebase -i` is...
Left some feedback mostly concerning CSS Grid and things. They're largely nits, but nits worth taking care of before this gets merged into main.
I don't think so! I'll mark this for CZO review, as that seems like the next step here, if Tim thinks it's ready for that.
That is annoying. See #29247 for the blurred-background solution that was merged for buttons on code blocks. You might look into replicating that in a follow-up PR for the message...