the-little-redis-book
the-little-redis-book copied to clipboard
karlseguin
A bunch of non-technical changes, mostly minor.
I made a bunch of fixes, mostly for consistency. I didn't make any technical changes. There are still more changes that could be made, but I wanted to see what you think of what I've done so far before doing them.
Sorry to be slow on this request. To be honest, I'm pretty hesitate as a lot of this seems subjective and stylistic. For example, I'm not a fan of a comma before "and", and it's my understanding that it's ok either way, so why change it?
On 1/31/2014 5:49 PM, Karl Seguin wrote:
Sorry to be slow on this request. To be honest, I'm pretty hesitate as a lot of this seems subjective and stylistic. For example, I'm not a fan of a comma before "and", and it's my understanding that it's ok either way, so why change it?
It all depends on whether you're trying for a book that's both technically correct (which I can't comment on) and easy to read. One way to be easy to read is to be consistent, which you're not. For example, sometime you use "A, B and C", and sometimes you use "A, B, and C".
I had said in the pull request that the changes I made were stylistic. Of course you're free to take them or leave them, but I believe your book would be of higher quality if you took them.
Jon