dust_extinction
dust_extinction copied to clipboard
Move input unit conversion and bounds checking to base class
There are two goals of this PR:
- Self-document what units these models expect by advertising the models in standard astropy.modeling.Model metadata.
- Eliminate input preparation code that was previously duplicated in every dust extinction model subclass.
Please add a description to this PR to describe in words the goal. Thanks.
Codecov Report
Attention: Patch coverage is 97.53086% with 2 lines in your changes missing coverage. Please review.
Project coverage is 99.66%. Comparing base (
d2e54ba) to head (4b977da). Report is 5 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| dust_extinction/baseclasses.py | 90.47% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
- Coverage 99.89% 99.66% -0.23%
==========================================
Files 9 9
Lines 938 900 -38
==========================================
- Hits 937 897 -40
- Misses 1 3 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please add a description to this PR to describe in words the goal. Thanks.
Done.