Karl Isenberg

Results 333 comments of Karl Isenberg

Why id this safe to re-apply now?

I mean, if we reverted it before, why is it now safe to reapply? What changed?

@code-review-assist review

On a related note: It would be nice if the diff --diff-type and update --strategy used the same flag name and the same flag values. I could file another FR...

If `setup-envtest` had git tags, that might provide a workaround. Currently, if you try to `go get sigs.k8s.io/controller-runtime/tools/setup-envtest` you get an auto-generated version number, because it's not taking the parent...