karlicoss comments

Results 351 comments of


                                            karlicoss

False negative when accessing dataclass instance attribute as class attribute

Ah interesting, thanks! Yeah, makes sense to have it for dataclasses at least.

some .opt(exception=...) quirks and trying to log exception without sys.exc_info

Ah thanks for explaining! > The behavior of logger.exception() would become dependent on the external state of opt() I feel like it's the whole point of .opt though! It contains...

Internal Server Error, json doesn't get written to.

Hey -- I got same error a couple of times in the past week (I have daily exports) -- it's possible they are experiencing some intermittent issues? I'll see if...

Internal Server Error, json doesn't get written to.

Hey, I pushed a fix to master that should retry in case of internal server error -- you wanna try it out? There are a couple of problems with the...

DE locale is guessed instead of EN due to a missing `Semantic Location History` regex

> I think you should be able to temporarily override Yep, I found the env variable! But considering the default is guessing and most users would expect EN locale, it...

use ParamSpec for pytest.skip instead of call Protocol attribute

Hi @bluetech -- sorry, just got around to try this, did on a separate branch (just on `skip` to start with) https://github.com/pytest-dev/pytest/commit/56b3937ea3e1317022d47b41a00b55c246448af2 Something like this (If I understood your suggestion...

use ParamSpec for pytest.skip instead of call Protocol attribute

Hi @bluetech -- any thoughts on this? :)

use ParamSpec for pytest.skip instead of call Protocol attribute

Thanks for suggestions @bluetech! Converted all of `skip/fail/etc` to simple protocols with `__call__` and it looks quite clean now, and types are simpler, so hopefully less chances of type checkers...

use ParamSpec for pytest.skip instead of call Protocol attribute

Thank you! Appreciate your time

failure during `_warn_if_no_activity()` on windows

Yeah, I don't have strong opinion about exposing it in the library. We could probably achieve similar results by using `@warn_if_empty` decorator in HPI? The only tricky thing (regardless whether...