Karl Horky

Results 973 comments of Karl Horky

getting close! almost 95% now as of 20 Mar 2024 - https://twitter.com/bunjavascript/status/1770298099833151867

Bun 1.1 supports Windows! - https://x.com/bunjavascript/status/1774842587431719184 - installable via PowerShell or npm https://x.com/bunjavascript/status/1774966012745814120

@mxschmitt @pavelfeldman @Skn0tt what do you think of this PR? Would be great to be able to specify the Playwright test directory with a `create-playwright` option.

@mxschmitt oh, that's disappointing. It's a pretty simple option (very few lines of code), and won't introduce too much maintenance overhead. Not sure why the PR is not accepted.

@mxschmitt thanks for the merge of #118 🙌 This PR was stacked on #118, and since it's been merged, I've merged from `main`, fixed the conflicts and marked this PR...

Merged from `main` and fixed conflicts again.

Since this is a pretty big PR, and contains other improvements such as [use conditional types and `infer` types to avoid duplicating options in 2 places](https://github.com/microsoft/create-playwright/pull/119#discussion_r1533067875), I think I'll split...

@mxschmitt too bad, it's disappointing that small features are not considered in different ways. It's discouraging to my motivation, as a community member who wants to contribute.

@AkaraChen was this already fixed + merged in the following PR? - https://github.com/microsoft/create-playwright/pull/102 Seems like it was released in [`[email protected]`](https://github.com/microsoft/create-playwright/releases/tag/v1.17.131)

Our students were also running problems after we enabled the `no-namespace` rule, with both `no-var` reports on `declare global...var` and `no-namespace` reports on `declare module globalThis...let`: - https://github.com/typescript-eslint/typescript-eslint/issues/9582 We discourage...