cdk-notifier icon indicating copy to clipboard operation
cdk-notifier copied to clipboard

Make hash regex configurable

Open wolverian opened this issue 1 year ago • 1 comments

We use the Git commit hash to tag our images. Git hashes are shorter than container image tags, so the default regex that --ignore-hash-changes uses doesn't match them. It would be useful to be able to override this regex.

https://github.com/karlderkaefer/cdk-notifier/blob/b0d167d3f1ae6f6cec9b8e1886b7dcf8e8163539/transform/transformer.go#L219C35-L219C63

wolverian avatar Feb 14 '25 15:02 wolverian

Here's an example PR comment that wasn't filtered out because of this issue: https://github.com/Opetushallitus/koto-rekisteri/pull/817#issuecomment-2659537983

wolverian avatar Feb 14 '25 15:02 wolverian

@wolverian thanks for opening the issue, I think that is a useful new feature. I have released it now. you check documentation. You can set the regex by environment variable or command line argument. Additionally the comments also now get deleted if there are only hash changes

karlderkaefer avatar Feb 22 '25 11:02 karlderkaefer

@wolverian as this open source project im doing in free time and I get no money or donation for it, I would really some appreciate some feedback in form of simple "thank you" or just "it works" or "it does not work because..". This would keep me motivated to also give support on future feature request

karlderkaefer avatar Mar 02 '25 09:03 karlderkaefer

@karlderkaefer Thank you! I'm now testing this in https://github.com/Opetushallitus/koto-rekisteri/pull/907.

wolverian avatar Mar 04 '25 11:03 wolverian