Christian Karl

Hey, thanks for your interest and sorry for the delay, in the end I decided to take a few days off of programming over the holidays. I am not 100-percent...

Thanks a lot for your detailed comments! Glad you like the general idea. * I agree toggling is currently cumbersome. In principle one could add a custom keybinding like `enter...

Absolutely no worries, I am also currently rather busy and will probably not find the time to work on this in the next few weeks unfortunately. - `gf` sounds good...

All right, this took a while but finally there is some more progress :blush: - The two bindings have been added, although `gF` ends with `open-selected` instead of `enter image`...

I like the idea of having additional "internal" keys, but I am not sure I like mixing this with the `ExifHandler` directly. The code is already quite involved there. I...

That was fast, awesome, thanks for the PR! I really like using `QImageReader` for this, that makes a lot of sense. I still feel like an additional class for the...

Awesome, thank you, and as always: no hurry! :blush:

So you did end up adding another class which combines the two handlers. Personally, I like this a lot, we keep the fetching and combining logic separated. Only downside is...

Oh, sorry, the wording "expose" was probably rather bad. I fully agree that no-one should have to bother where metadata comes from. What I meant was to make the `_ExternalKeyHandler`...

Concerning the unit-tests: I agree that we should probably test them all in a nice and isolated fashion in `tests/unit/test_metadata.py`. As we no longer have the setting defining which metadata...