Christian Bewernitz

Results 281 comments of Christian Bewernitz

I actually decided to no longer log a warning for missing attribute values at all in the context of HTML documents as part of #338, which as been released as...

The fix was published as version 0.9.0-beta.11 (as the `next` tag). Please let me know if all your cases are covered.

The priority for this is very low at our end, but if somebody creates a PR with one of the two solutions we will follow up on it. If someone...

If the internal symbol solution is possible in ES5, it sounds like that is the solution which requires less code and is easier to follow.

Has improved a lot, even though no discussion took place outside of this thread

We are no longer using stryker mutation testing, so this PR is obsolete

@shunkica the page you linked to also says that the HTMLCollection is a deprecated interface. I think the LiveNodeList is our equivalent/closest implementation, even though it is missing the name...

In general I think every small improvement is great, not every touched code has to be 100% aligned to a spec in order to be merged. We have to go...

Since we have landed #489 I will close this issue, since we now support all entities and according to the standard this list is fixed. https://html.spec.whatwg.org/multipage/named-characters.html#named-character-references PS: I'm considering to...

@marrus-sh This might already be resolved since https://github.com/xmldom/xmldom/releases/tag/0.9.0-beta.7 (which is currently available as the `next` version on npm). Do you have time to verify that I didn't miss any case?