Karen Etheridge

small improvements for the discriminator keyword, from the spec

For example, 50X is NOT permitted. This was fixed in v3.1 in PR#2690 but the change did not make it to v3.2.0.

also test allOf schemas presented in the reverse order

1

Nothing in the specification says that allOf subschemas are evaluated in order; if they are evaluated in the reverse order an erroneous implementation could still pass this test.

no tests for unicode codepoints vs. utf8-encoded characters

4

no time to create a PR right now, so dropping this here to come back to, and for discussion in case for some reason this is controversial: schema: `{ "maxLength":...

multiple levels of indentation not handled

1

Multiple levels of `=over 4` are not visible in the site redesign -- everything appears at the same level, so it's impossible to tell what content is meant to be...

I see that the way to change between database indexes is with `$client->select()` -- could you please document this? Also, is there a way to select the database index at...

Allow statements as well as structures and tokens to be inserted adjacent to a token

5

Otherwise, this would be impossible: ``` my $doc = PPI::Document->new(\ "1;\n"); my $token = $doc->last_element; my $new_document = PPI::Document->new(\ '$foo = 1;'); $token->insert_after($_) foreach reverse $new_document->schildren; ```

content is read as octets, not characters, with no concept of decoding

19

`new($filename)` reads the file as bytes, with no encoding layers, so any content that isn't Latin1 will cause issues. `new(\$content)` is read exactly the same way. Files need to be...

Perl::Critic::Utils should be moved to something like PPI::Helpers

12

There's lots of useful generic stuff in Perl::Critic::Utils, and various things (e.g. Perl::MinimumVersion) call into it to do its code parsing. I'd like to consider we take on this code...

missing configure-requires prereq declaration

5

I got this while installing into a virgin 5.20.0 build: ``` Configuring PPI-1.220 Running Makefile.PL Can't locate IO/All.pm in @INC (you may need to install the IO::All module) (@INC contains:...