react-items-carousel icon indicating copy to clipboard operation
react-items-carousel copied to clipboard

fix(helpers): condition to check if we reached the end of the carousel for translateX

Open YassineHaouzane opened this issue 2 years ago • 2 comments

This PR fixes the following bug :

Animation As you can see the right arrow is still displayed when we reach the end of the carousel.

You can reproduce this bug with this configuration:

{
  "noOfChildren": 4,
  "wrapperStyle": {
    "padding": "0 60px",
    "maxWidth": 763,
    "margin": "0 auto"
  },
  "componentProps": {
    "infiniteLoop": false,
    "activePosition": "left",
    "numberOfCards": 1.8,
    "slidesToScroll": 1.8
  }
}

YassineHaouzane avatar Feb 21 '23 17:02 YassineHaouzane

Its not working with typescript

noumankhandatu avatar Jun 06 '23 07:06 noumankhandatu

Could not find a declaration file for module 'react-items-carousel'. 'c:/Projects/Leximind/leximid-dashboard/node_modules/react-items-carousel/dist/react-items-carousel.js' implicitly has an 'any' type. Try npm i --save-dev @types/react-items-carousel if it exists or add a new declaration (.d.ts) file containing declare module 'react-items-carousel';

noumankhandatu avatar Jun 06 '23 07:06 noumankhandatu