Daniel Theophanes

Results 79 comments of Daniel Theophanes

This driver does indeed use way too many goroutines. So in a sense, yes, that was how it was implemented. Should it, probably not.

@mac2000 I would advise you to look at buffering your results to file. .NET by default buffers writes to a file, where as Go does not, so in Go you...

@denisenkom That looks great! I think to support cancellations, we should use another go routine. I think there are three levels that it can be implemented: (1) Per Connector, (2)...

@wrosenuance I just sent a review #546 . I'm going to wait for that PR to merge before doing a review on this one, but doing a skim on this...

I've merged #546, please rebase on master and I'll review this closely.

@wrosenuance Thank you for the updates. There are a number of changes going on and it will take me a few days to review. Thank you for being patient with...

Sorry for the delay. This year has been a blast. I've stared this change, will try get to it.

@wrosenuance Thank you for doing this. I just went through this an initial time in this form. This change is large. Would it be possible for you to open a...

If you could start with just the changes to mssql package, both tokens and function changes, that would be great.

Are you able to reproduce this without sqlx or testify?