awmp icon indicating copy to clipboard operation
awmp copied to clipboard

I hope you can add Actix web 4 version support

Open zhangwuqiao opened this issue 4 years ago • 5 comments

[dependencies] actix-web = "4.0.0-beta.10"

thanks!

zhangwuqiao avatar Nov 06 '21 08:11 zhangwuqiao

I was planning on just waiting until 4.0 final is released to add this.

If you would like to go ahead and make a PR supporting the beta, I would be happy to go ahead and merge it and release.

kardeiz avatar Nov 11 '21 03:11 kardeiz

Hi!

Actix-web 4 just released! :) Is there a chance that this crate will support it in the near future?

horvbalint avatar Feb 25 '22 21:02 horvbalint

Hi @horvbalint @zhangwuqiao ,

I've just added support for actix-web 4 in version 0.8.0. I tested the new example and everything seems to work fine, but please let me know if you have any issues!

kardeiz avatar Feb 26 '22 18:02 kardeiz

Wow, That was fast! Thank you a lot! I tried it out and it is working just fine for my (not too demanding) use-case. One thing: Maybe you should concider changing the App::data() call in the example to App::app_data() as the first one is deprecated now. https://github.com/actix/actix-web/blob/master/actix-web/MIGRATION-4.0.md#appdata-deprecation-warning

horvbalint avatar Feb 26 '22 18:02 horvbalint

@horvbalint Thanks, I saw that, and will do so in the near future.

I'm also planning on wrapping the PartsConfig so that it doesn't matter whether the user adds it to app_data as web::Data<PartsConfig> or just PartsConfig. None of the signatures will change and it will be a minor version update probably later this week.

kardeiz avatar Feb 26 '22 20:02 kardeiz