retrail.nvim icon indicating copy to clipboard operation
retrail.nvim copied to clipboard
verified publisher icon kaplanz

Exclude buffers matching on `buftype`

Open I60R opened this issue 3 years ago • 2 comments

  • quickfix
  • help
  • terminal
  • prompt

I60R avatar Nov 22 '22 13:11 I60R

Thanks for the contribution!

Just a brief point of discussion, should we consider adding this as a configurable option? I can't imagine why users would want Retrail enabled in a quickfix buffer (and I'm under the impression that buftype is only set to help when using :help), nevertheless, who knows what users may want.

I completely agree that if we add that as an option we should at least disable over those buftypes as the default. What do you think?

kaplanz avatar Nov 22 '22 14:11 kaplanz

nevertheless, who knows what users may want.

There would be really few users who want retrail being enabled in a quickfix buffer :smile:

Anyway, this PR first of all fixes retrail being enabled in terminal window

I60R avatar Nov 22 '22 16:11 I60R

Thanks for all the work into this! I've just been finishing up exams so I'm sorry it's taken a while to review these changes. I finish later this week, and will do a full review then.

kaplanz avatar Dec 17 '22 23:12 kaplanz

Sorry this took to long to get around to! There were a few bugs I had to sort out (see here and here, where filetype and buftype were accidentally swapped). Please let me know if there's any issues with this feature on your end.

Thanks a ton for your PR and work on this! I've made sure to mark you as the author on these commits.

kaplanz avatar Jan 13 '23 18:01 kaplanz