Kapil Thangavelu

@thisisshi ping ^

good catch, yeah we should probably excise all of those from tests to use assert equal .. note since we're using pytest we could also just assert x == y...

there's quite a few of these ``` ./tests/test_webhook.py: self.assertTrue(self.load_policy(data=policy, validate=True)) ./tests/test_webhook.py: self.assertTrue(self.load_policy(data=policy, validate=True)) ./tests/test_sagemaker.py: self.assertTrue(tags[0]["Key"], "custodian_cleanup") ./tests/test_sagemaker.py: self.assertTrue(len(resources), 1) ./tests/test_sagemaker.py: self.assertTrue(notebook["NotebookInstanceStatus"], "Pending") ./tests/test_sagemaker.py: self.assertTrue(len(resources), 1) ./tests/test_sagemaker.py: self.assertTrue(notebook["NotebookInstanceStatus"], "Stopping") ./tests/test_sagemaker.py: self.assertTrue(len(resources),...

there isn't any delete functionality directly supported by mailer cli, and. the mugc script won't pick it up, at the moment its a manual delete, but is there common cause...

do you have the full traceback from the logs on the mailer? the editor aspect in the console is a behavior of the aws lambda console and outside of our...

its a big pr, but mostly just wanted to note we should validate behavior wrt to resource batching, @mikejgray is noting a separate email per resource, where as it should...

@thisisshi can you resolve the conflicts, given your testing on behavior, I'm good to go with the pr as is.

looks like packaging conflicts got reintroduced by the 0.9.18 release prep pr merge.

Thanks for the pull request! If you don't mind could you sign the Linux Foundation/CNCF CLA referenced in the other comment.

Thanks for the pull request! If you don't mind could you sign the Linux Foundation/CNCF CLA referenced in the other comment. Direct link https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/14202841/52837350/7532/#/?version=2