Kapil Thangavelu

Results 392 comments of Kapil Thangavelu

@mingyugg understood on the utility, one other question in the library is the hardcoded region on STS in the library, is this a global region, or is something that needs...

thanks for the changes, overall looks good, It does feel like their is some extraneous recording data though wrt to the volume of json in the pr, I haven't dived...

@scolebrook no problem, thanks for working on it and making it happen.

I would suggest renaming the variable, max-increment-count perhaps or max-increment-step, if its only used for going up on sizes.

its also worth noting there are some environment variables from aws sdk re retry style that can also be helpful. https://boto3.amazonaws.com/v1/documentation/api/latest/guide/retries.html we also added a bit better retry jitter recently...

Memory and cpu are determined by resource cardinality, cpu utilization is typically dominated by transport/tls encryption on api calls. also you claim an increase but haven't provided a baseline

Thanks for the pull request! If you don't mind could you sign the Linux Foundation/CNCF CLA referenced in the other comment. I believe your org already has cloud custodian as...

> This looks good to me, though based on the test failures maybe we need to update the [list of known Config resource types](https://github.com/cloud-custodian/cloud-custodian/blob/0e523b0f09a7ad92860711b1e5c2922e0d9afcd5/tests/test_policy.py#L375). > > Have you been referencing...