kapitan icon indicating copy to clipboard operation
kapitan copied to clipboard

Add --tree-style-output compile option

Open roman8422 opened this issue 4 years ago • 12 comments

Fixes issue #679

Proposed Changes

Add an option to not create folders with target names and instead merge output_paths of all targets in one tree.

roman8422 avatar Jan 15 '21 05:01 roman8422

Overall looks reasonable, but tests expect a different directory structure I believe so they should also be adjusted/fixed before merging.

uberspot avatar Jan 15 '21 09:01 uberspot

Hey @roman8422 thanks for this - can you add a few test cases?

ramaro avatar Jan 28 '21 13:01 ramaro

Hey @roman8422 thanks for this - can you add a few test cases?

Sure. I've had some personal stuff to deal with lately. Will fix this PR in the next couple of weeks. Thanks for willingness to accept it.

roman8422 avatar Jan 28 '21 13:01 roman8422

Hey @roman8422 any luck with this?

ramaro avatar Jul 12 '21 20:07 ramaro

@ramaro I pushed my latest code change but I can't make unit tests work on master branch before I even start writing tests for my code. Looks like it is related to this issue https://github.com/kapicorp/kapitan/issues/358. Any advice how to overcome this?

roman8422 avatar Jul 28 '21 08:07 roman8422

Thanks @roman8422 ! No problem, this is a known issue which we're fixing with the latest merges. I think this is good to go so merging. Thanks again

ramaro avatar Aug 01 '21 13:08 ramaro

@roman8422 you should be good to proceed now!

ramaro avatar Aug 05 '21 21:08 ramaro

@ramaro "Docker Build and Push" action is constantly failing. Is there something I can do to fix that?

roman8422 avatar Oct 11 '21 23:10 roman8422

@roman8422 thanks for the patience. This looks good, thanks! Merging.

ramaro avatar Nov 28 '21 14:11 ramaro

@ramaro I noticed that this PR wasn't merged and pushed a minor typo fix. Any plans to merge it any time soon? Edit: I see there are merge conflicts. Will resolve them and push new change.

Roman-Clumio avatar Apr 02 '22 02:04 Roman-Clumio

@roman8422 apologies, I meant to merge this for v0.30 for missed it. Merging now so it will be official in v0.31. Thank you!

ramaro avatar Apr 12 '22 20:04 ramaro

@roman8422 actually no, sorry - spoke too soon as tests don't pass

ramaro avatar Apr 12 '22 21:04 ramaro