LibreLingo icon indicating copy to clipboard operation
LibreLingo copied to clipboard

Remove Mandatory Definition for words

Open nprime496 opened this issue 9 months ago • 1 comments

I am trying to install the repo locally but I stumble upon this error:

RuntimeError: Error while exporting skill "Chiffres 2" in file "4_Numbers/skills/4_Numbers_2.yaml": The French word "téléphones" does not have a definition. Please add it to the mini-dictionary.

Reading the code, I notice that there's a check to ensure that all words have a correspondance in mini-dictionnary:

https://github.com/LibreLingo/LibreLingo/blob/3bb6d4deadc27cf7b762fcf63d7bb07ea0ccaac8/src/librelingo_json_export/dictionary.py#L52C1-L56C1

I do not think that it is necessary as it put too much constraints on course creation. Dictionnary should be added to improve existing courses not be an unavoidable requirement.

nprime496 avatar May 17 '24 20:05 nprime496