reminiscence
reminiscence copied to clipboard
kanishka-linux
logo added
Hi there, I think I made some miscommunication...You don't have to make special pull request to master branch. Previous pull request to testing branch with updates was sufficient. I'll test updated changes, and will first merge them with testing branch. And after few days, I'll merge them with master branch.
Edit: In short you just have to make pull request to testing branch, I'll do the rest.
Oh sorry, I wiped the old fork to send the new pull-request. So I sent a new pr to the test branch.. I can't using Github very well. I don't want to ruin your repository. If it is still wrong, please download the files from the googdrive.
https://github.com/kanishka-linux/reminiscence/pull/18
https://drive.google.com/open?id=1EWn-x4LDzv3gJJheFK-O5BtYYVqglVgs
oh, don't worry! Things like this happen. That's why testing and addition of new features are mostly done on separate branch. You'll get used to it.
I use github mostly from command-line, therefore I've saved a copy of your previous work. I use web-interface only for comments and issues.
I didn't know that one can read svg files. I wan't to discuss about few things about metadata written in it, before merging it to master branch. If possible can you share your email id for discussing it. Alternatively, my email id is given in my github profile page, which you can use to contact me.