pytorch-skipthoughts icon indicating copy to clipboard operation
pytorch-skipthoughts copied to clipboard

Naming issue

Open mikekestemont opened this issue 7 years ago • 1 comments

https://github.com/kaniblu/pytorch-skipthoughts/blob/6ce13492dc6d4f0378ead8ec5aadb151cc79d93f/src/torchst/train.py#L49

Probably iter should be step here?

mikekestemont avatar Dec 30 '17 19:12 mikekestemont

Nice find. I am currently working on a major update that can replicate results in arXiv:1607.06450 and work faster in Multi-GPU environment. This minor issue should be fixed by then.

kaniblu avatar Jan 01 '18 12:01 kaniblu