compat-table icon indicating copy to clipboard operation
compat-table copied to clipboard

Update node engine in package.json

Open chicoxyzzy opened this issue 9 years ago • 4 comments

We have node 0.11.12 as a lower node version and that's weird. Should we change it to 4.7.0 or maybe even 0.10.48?

chicoxyzzy avatar Dec 28 '16 22:12 chicoxyzzy

Indeed, it should be as low as is required. However, I'm not sure if npm run build still works on node 0.10 - can someone verify the lowest node version it works on, and we'll adjust the engines field to match?

The original commit that added this, however, indicates why it requires 0.11.12 or later - so I think that the only thing we'd need to do is raise it higher, if in fact it doesn't still work on 0.11.12.

ljharb avatar Dec 29 '16 09:12 ljharb

npm run build and npm run build:compilers both work on v0.10.48. Would be great if @webbedspace will chime in.

chicoxyzzy avatar Dec 29 '16 14:12 chicoxyzzy

I don't think that it make any sense. We could just remove it.

zloirock avatar Dec 29 '16 14:12 zloirock

"engines" is important advisory information that, while not required, is still useful to have.

ljharb avatar Dec 29 '16 18:12 ljharb