compat-table icon indicating copy to clipboard operation
compat-table copied to clipboard

Custom compat tables

Open p-bakker opened this issue 3 years ago • 2 comments

As discussed in #1790 a prototype to allow creating custom compat tables

Usage node build environments=./custom.json excludecurrent

With custom.json being a custom environments file, for example having the following content:

{
  "rhino1_7_13": {
    "full": "Rhino 1.7.13",
    "short": "Rhino 1.7.13",
    "family": "Rhino",
    "platformtype": "engine",
    "release": "2020-09-02"
  },
  "rhino1_7_14": {
    "full": "Rhino 1.7.14",
    "short": "Rhino 1.7.14",
    "family": "Rhino",
    "platformtype": "engine",
    "release": "2022-01-06"
  }
}

This PR is a draft, just to get the discusion going. Needs cleanup + more:

  • Hide engines from the legenda that aren't used in the provided environments file
  • Hide unstable/obsolete checkboxes if the provided environments file doesn't contain any unstable/obsolete browsers
  • Remove sort by Engine Type, if only one engine type is is used with the environments file
  • Remove entire platformType header if the browsers in the environments file are all of the same platformType

One question: the code in build.js isn't using modern JavaScript features. Is that on purpose?

Closes #1790 Closes #1198

p-bakker avatar Feb 12 '22 16:02 p-bakker

Having to make some adjustments to the es*/skeleton.html files, I'm wondering if I should be bothered to look at the es*/compiler-skeleton.html files as well.

Are they still being used? They don't seem to be hosted on https://kangax.github.io/compat-table/

p-bakker avatar Feb 13 '22 12:02 p-bakker

@ljharb appreciate it if you could have another look at the direction of this PR: in https://github.com/kangax/compat-table/pull/1791/commits/35bd089b3c583a7b5a5c74f7ebbd36e6aad2dbee I added the option to augment the testresults already available in this repo, as to allow supplying testdata, for example for nightlies of environments that are already part of this repo or to supply test results for environments that aren't in this repo (yet)

Also updated the readme with the new options and addresses previous review comments

If this all still looks good, last step will be to hide some more things form the UI, based on which environments are included

p-bakker avatar Feb 14 '22 11:02 p-bakker

Parece que proporcionaste información sobre dos versiones diferentes del software Rhino cool !!!!

Da664458658574875567 avatar Aug 15 '23 22:08 Da664458658574875567

Closing this PR in favor of #1881 and yet to create follow-up PRS that offer a cleaner, more versatile approach

p-bakker avatar Oct 13 '23 19:10 p-bakker