compat-table icon indicating copy to clipboard operation
compat-table copied to clipboard

"Flagged" issues for Chrome should have a note on how to enable them

Open afmenez opened this issue 8 years ago • 9 comments

There are many issues marked as "flagged" for Chrome that have no clue on how to enable them. On pull #1168 I added a new note chrome.harmony that may apply to some of these issues, but I was not able to find which ones. Someone which more Chrome insight could update them.

afmenez avatar Sep 08 '17 18:09 afmenez

I have added all the other features enabled by chrome.harmony on Chrome 61 to pull #1168. What is missing:

  • Notes for the chrome.harmony flag on versions < 61;
  • Other flags that enable the remaining issues;

afmenez avatar Sep 10 '17 20:09 afmenez

According to @gsathya, only the --harmony flag enables complete and stable features (see #1170). The other flags enable features that are incomplete or unstable. My plan now is to remove the notes for these flags, keeping only the one for --harmony, and changing the associated features to false instead. Any opposition? @chicoxyzzy? @ljharb?

afmenez avatar Sep 11 '17 14:09 afmenez

compat-table shows not only stable features. Actually all features from esnext tab are unstable. We should indicate if some ebvironments support those features (no matter under distinct flag or not)

chicoxyzzy avatar Sep 11 '17 14:09 chicoxyzzy

We are talking about different kinds of unstable. An unstable feature means it is not complete yet and may change. An unstable implementation means it does not follow the specification or that it may crash the browser. If I understand correctly, what @gsathya is saying on #1170 is that when a feature is behind a specific flag, it is because it is not considered ready for testing. As soon as it is considered ready to test, it is moved to the --harmony flag.

afmenez avatar Sep 11 '17 14:09 afmenez

I still don't agree with you.

An unstable feature means it is not complete yet and may change.

All esnext features are unstable in that meaning.

An unstable implementation means it does not follow the specification or that it may crash the browser.

esnext features are not in specification

it is because it is not considered ready for testing

If it is implemented and shipped than we should (and we actually do) test them

chicoxyzzy avatar Sep 11 '17 14:09 chicoxyzzy

An unstable feature means it is not complete yet and may change.

All esnext features are unstable in that meaning.

Yep.

An unstable implementation means it does not follow the specification or that it may crash the browser.

esnext features are not in specification

My bad, they have a proposal.

it is because it is not considered ready for testing

If it is implemented and shipped than we should (and we actually do) test them

My patch keeps the note on how to enable them, just removes the "flagged" marking.

afmenez avatar Sep 11 '17 15:09 afmenez

My patch keeps the note on how to enable them, just removes the "flagged" marking.

That does make sense to me. Let's see what others think

chicoxyzzy avatar Sep 11 '17 15:09 chicoxyzzy

Seems like we have consensus here. #1173 is merged

chicoxyzzy avatar Sep 11 '17 15:09 chicoxyzzy

My patches only implement this for some of the flags, and only for Chrome >= 61. My intention with this bug was to have all of them fixed.

afmenez avatar Sep 11 '17 16:09 afmenez