compat-table icon indicating copy to clipboard operation
compat-table copied to clipboard

Decorator proposal has been changed in Stage 2

Open trotyl opened this issue 8 years ago • 9 comments

The current test of class & property decorator is still based on the proposal in stage 1, and currently there is no implementation that fullfils the proposal in Stage 2, nor Babel or TypeScript.

It's not correct while list decorator in Stage 2 but test the proposal for decorator in Stage 1.

trotyl avatar Jan 10 '17 14:01 trotyl

I guess someone needs to write a Babel transform...

/cc @hzoo @boopathi @shinew

kangax avatar Jan 10 '17 23:01 kangax

@kangax this needs Babylon parser support first and this work was started by @DrewML recently :) https://github.com/babel/babylon/pull/236

chicoxyzzy avatar Jan 11 '17 00:01 chicoxyzzy

Yep! Just waiting on some clarifications from Yehuda and some decisions about versioning/breaking changes before we finish it out and move on to the transform.

DrewML avatar Jan 11 '17 00:01 DrewML

In the meantime, I think it would be appropriate to mark nobody as supporting decorators, since nobody supports stage 2 semantics. We should probably also update the tests so that they will help once somebody does support it.

ljharb avatar Jan 11 '17 01:01 ljharb

@kangax Would you accept a PR to update the decorator tests to follow the current version of the proposal?

hybrist avatar Mar 15 '17 21:03 hybrist

@jkrems that'd be great, yes! please update the results as well :-)

ljharb avatar Mar 15 '17 21:03 ljharb

Done: https://github.com/kangax/compat-table/pull/1047

hybrist avatar Mar 15 '17 21:03 hybrist

Can't this one be closed now that the patch was merged?

afmenez avatar Aug 01 '17 19:08 afmenez

@afmenez #1047 isn't merged yet.

ljharb avatar Aug 01 '17 19:08 ljharb