Winbuilder notes to fix in CRAN submission.
* using log directory 'd:/RCompile/CRANguest/R-devel/bigmemory.Rcheck'
* using R Under development (unstable) (2017-03-24 r72390)
* using platform: x86_64-w64-mingw32 (64-bit)
* using session charset: ISO8859-1
* checking for file 'bigmemory/DESCRIPTION' ... OK
* this is package 'bigmemory' version '4.5.22'
* checking CRAN incoming feasibility ... Note_to_CRAN_maintainers
Maintainer: 'Michael J. Kane <[email protected]>'
* checking package namespace information ... OK
* checking package dependencies ... NOTE
Package which this enhances but not available for checking: 'synchronicity'
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for hidden files and directories ... OK
* checking for portable file names ... OK
* checking whether package 'bigmemory' can be installed ... OK
* checking installed package size ... OK
* checking package directory ... OK
* checking 'build' directory ... OK
* checking DESCRIPTION meta-information ... OK
* checking top-level files ... OK
* checking for left-over files ... OK
* checking index information ... OK
* checking package subdirectories ... OK
* checking R files for non-ASCII characters ... OK
* checking R files for syntax errors ... OK
* loading checks for arch 'i386'
** checking whether the package can be loaded ... OK
** checking whether the package can be loaded with stated dependencies ... OK
** checking whether the package can be unloaded cleanly ... OK
** checking whether the namespace can be loaded with stated dependencies ... OK
** checking whether the namespace can be unloaded cleanly ... OK
** checking loading without being on the library search path ... OK
** checking use of S3 registration ... OK
* loading checks for arch 'x64'
** checking whether the package can be loaded ... OK
** checking whether the package can be loaded with stated dependencies ... OK
** checking whether the package can be unloaded cleanly ... OK
** checking whether the namespace can be loaded with stated dependencies ... OK
** checking whether the namespace can be unloaded cleanly ... OK
** checking loading without being on the library search path ... OK
** checking use of S3 registration ... OK
* checking dependencies in R code ... OK
* checking S3 generic/method consistency ... OK
* checking replacement functions ... OK
* checking foreign function calls ... OK
* checking R code for possible problems ... OK
* checking Rd files ... OK
* checking Rd metadata ... OK
* checking Rd line widths ... OK
* checking Rd cross-references ... OK
* checking for missing documentation entries ... OK
* checking for code/documentation mismatches ... OK
* checking Rd \usage sections ... OK
* checking Rd contents ... OK
* checking for unstated dependencies in examples ... OK
* checking line endings in C/C++/Fortran sources/headers ... OK
* checking compiled code ... NOTE
File 'bigmemory/libs/i386/bigmemory.dll':
Found no calls to: 'R_registerRoutines', 'R_useDynamicSymbols'
File 'bigmemory/libs/x64/bigmemory.dll':
Found no calls to: 'R_registerRoutines', 'R_useDynamicSymbols'
It is good practice to register native routines and to disable symbol
search.
See 'Writing portable packages' in the 'Writing R Extensions' manual.
* checking sizes of PDF files under 'inst/doc' ... OK
* checking installed files from 'inst/doc' ... OK
* checking files in 'vignettes' ... OK
* checking examples ...
** running examples for arch 'i386' ... [2s] OK
** running examples for arch 'x64' ... [2s] OK
* checking for unstated dependencies in 'tests' ... OK
* checking tests ...
** running tests for arch 'i386' ... [4s] OK
Running 'testthat.R' [4s]
** running tests for arch 'x64' ... [7s] OK
Running 'testthat.R' [6s]
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes in 'inst/doc' ... OK
* checking re-building of vignette outputs ... [6s] OK
* checking PDF version of manual ... OK
* DONE
Status: 2 NOTEs
Thanks for the pull request. I'm uploading the new version to CRAN now. I'll close when it's accepted.
multiplyr and bigpca are broken. I'll be able to take a look later in the week.
@kaneplusplus I didn't think multiplyr was dependent on bigmemory?
multiplyr, not multidplyr.
But it is interesting that someone developed something for data.frames based on bigmemory :-).
This package is not (yet!) a complete replacement for dplyr
I already like it. I'll take a look.
Thanks for the correction, I've updated my original comment. Also, thanks very much for taking a look.
multiplyr done: https://github.com/jeblundell/multiplyr/pull/20 I let you see with the author for the details related with resubmission.
Note that subsetting with booleans doesn't work. E.g.
a <- big.matrix(2, 2)
a[c(FALSE, TRUE), 2] <- 1
I'll check bigpca tomorrow. GN.
Multiplyr has some other problems that I don't have when testing it locally.. I don't understand the problem, sorry.
For bigpca, the error comes from this line: https://github.com/cran/bigpca/blob/master/R/bigpca.R#L1491
Note that next.row is a character vector of numbers. It is like doing this:
a <- big.matrix(2, 2)
a[1, ] <- c("0.1", "2.4")
Was this even possible in the past?
Putting as.numeric() around next.row in this line (and the previous line) solves the problem.
Negative, we have never supported character types. Thanks for taking a look. I think I can take a look this weekend.