slim-twig-flash icon indicating copy to clipboard operation
slim-twig-flash copied to clipboard

Update for Twig 3

Open slokhorst opened this issue 5 years ago • 6 comments

Fixes #6

slokhorst avatar Dec 19 '19 11:12 slokhorst

Yes, thanks for this @slokhorst !

@kanellov Can you please merge this/release a new version (probably new major bc this is a breaking change)?

koelle25 avatar Jan 16 '20 15:01 koelle25

Oh, @slokhorst , maybe you can update the twig requirement in composer.json to ^3.0 and add it to this PR.

koelle25 avatar Jan 16 '20 15:01 koelle25

@koelle25 I think these new class names were backported to the 1.x and 2.x branches too (commit): image

And see also the changelog.

So it seems to be ^1.34.0 || ^2.4.0 || ^3.0.0, although I've not tested the 1.x and 2.x branches myself.

slokhorst avatar Jan 16 '20 20:01 slokhorst

I copied the class with the modifications in the PR into my Slim Framework 4 app alongside Twig 3, and this works quite nicely. A merge would be splendid. Thanks!

will-in-wi avatar Mar 28 '20 13:03 will-in-wi

bump

Root3287 avatar May 10 '21 17:05 Root3287

I forked it and fixed compatibility with slim/flash 0.4.

To use it in your composer add the following:

{
  "repositories": [
    {
      "url": "https://github.com/winteragency/slim-twig-flash.git",
      "type": "git"
    }
  ],
  "require": {
    "kanellov/slim-twig-flash": "dev-master"
  }
}

rlunden avatar Nov 23 '21 10:11 rlunden