John Kane

Results 281 issues of John Kane

VSCode has added an api for enhancing source code with inlays. Typescript uses it to display inferred types for variables, among other things: ![image](https://user-images.githubusercontent.com/24030/157010020-b197975e-5f72-4bad-ae03-b32aeb973e65.png) Are there any places in solidity...

type:feature
status:ready

Raised in feedback: https://github.com/nomiclabs/hardhat-vscode-feedback/issues/18 The request is to populate the outline section of the explorer sidebar: ![image](https://user-images.githubusercontent.com/24030/151139366-6a4ae2f1-5247-4110-a0ad-612bc71100f4.png) I believe this requires implementing: `documentSymbolProvider` - https://code.visualstudio.com/api/language-extensions/programmatic-language-features#show-all-symbol-definitions-within-a-document Supporting `documentSymbolProvider` would also get...

enhancement

There are known attributes on `msg`, which should appear as the top completions.

bug

When completing an import: `import "./X"`, we should auto append the `;` to the end of the line. Our parsing is disrupted by the lack of a `;`.

enhancement

@alcuadrado reported this in the openzeppelin repo: > I'm using OZ Contracts for the navigation test > If I open this file in a new vscode process, after indexing, contracts/token/ERC777/IERC777.sol,...

bug

Feedback from @fvictorio. > it would be great if you could ctrl+click the "Greeter" in ethers.getContractFactory("Greeter") and be taken to the contract This would be an enhancement on the js/ts...

enhancement

This is feedback from @alcuadrado raised during manual testing in the openzeppelin repo. > I renamed a contract that is heavily used in OZ, it worked like a charm, I...

type:bug
status:ready

We perform indexing once at Language Server boot. If a user adds `@openzeppelin` via npm after lsp boot, the user will not see it in import completions. We should be...

type:feature
status:ready

If you have two contracts: ```solidity # A.sol // SPDX-License-Identifier: GPL-3.0 pragma solidity >=0.7.0 =0.7.0

type:bug
status:ready

To reproduce: ```solidity // SPDX-License-Identifier: GPL-3.0 pragma solidity >=0.7.0 =0.7.0

type:bug
status:ready