John Kane

icon indicating a website link https://www.kanej.me icon indicating an email [email protected]

icon company Molendinar Solutions Limited icon location Glasgow, Scotland icon location Javascript programmer with an interest in the dweb

Results 272 comments of John Kane

Add configurable maxFeePerGas and default to it if set

@zoeyTM can you open a PR for the docs, to add the new config option?

Two terms could do with definition

I am going to close this PR. We can reopen if get more changes to consider. We will review all our documentation with Hardhat 3.

Confusing error message when running in Optimism mode

@alcuadrado reported the message - is @Wodann on the right track here?

Communication via socket for test child processes' user interruptions

After discussion, we are going to close this PR - it help us understand the problem, but we intend to take a simpler approach to the child process context for...

Add detailed logging to SenderProvider and AutomaticSenderProvider

Hey @demoncoder-crypto, we addressed #6632 here: https://github.com/NomicFoundation/hardhat/pull/6721 Thanks for the hard work, but I am going to close out this PR.

Re-evaluate snippets

It looks as if there is now undocument but implemented file snippet support: https://github.com/microsoft/vscode/issues/145929

Using Ignition upgradable contract case in Hardhat 3 does not work

Thanks for the info. I was able to reproduce based on the steps above: ``` WARNING: You are using Node.js 20.19.0 which is not supported by Hardhat. Please upgrade to...

Using Ignition upgradable contract case in Hardhat 3 does not work

My apologies @hairyf, this issue slipped through the cracks. There is a feature `dependenciesToCompile` that will compile import contracts like `TransparentUpgradeableProxy`. If you add `dependenciesToCompile` to your `hardhat.config.ts` under `solidity`,...

Interruptions should be cancellable

This is a feature we will look to support. Currently it is planned for after the Beta launch.

Validation blocked due HH18: Corrupted lockfile, on Windows VSCode when using WSL hardhat project

Agreed. We should enhance the warning message to give guidance to WSL users. The platform specific elements of Hardhat, and our use of hardhat during validation of hardhat projcts, force...