John Kane

Results 272 comments of John Kane

Thanks @cameel, we are starting to plan out enhancements to our compilation pipeline as part of the next version of Hardhat so this is a really useful analysis. I will...

I suspect we would hesitate before increasing the complexity of the deserialization process. Currently it is JSON.parse with this one additional magic rule for bigints, any additional rules would have...

Hey @erhant, firstly thanks for the suggestions, we have been talking over the approach to take on this internally. Complexity in the deserializer we try and avoid, but support for...

The approach then would be to use `json5` when parsing the parameters.json file. We would retain the replacer function that converts strings of the "1000n" format to native javascript BigInts....

Thanks @luismasuelli, this is a bug. I have been able to reproduce it locally. We will take a look at your resolve path suggestion.

I am going to close this PR as we are porting Ignition to the Hardhat repo. We are also reworking the entirety of `hardhat.config.{js,ts}` for Hardhat 3. I think after...

Thanks for the reproduction repo, it really helps. I think the additional `chain` parameter makes sense as a solution.

Thanks @CedarMist we will take a look.

We massively appreciate the work put in here, but I am afraid we don't intend to merge this PR. Hardhat is currently in the process of a large upgrade as...

Hey @Stumble, thanks for the feedback. Can I check I have understood. Contract A gets deployed, then the deployment account is used to send some transactions, then you use Ignition...