kando-menu
:tada: Add behavior options for same shortcuts (#870).
I thought I would open this PR to discuss the current implementation as well as some nuance around turbo mode.
Let me know what you think!
Hi there! Sorry for the late reply! I was totally busy with the new settings dialog. But your implementation actually works quite well! There are only two things:
- It would be cool if the last menu used in the cycle mode was "remembered". So if I open the menu again, it will show the menu I used last time.
- Single-Key Turbo Mode. This is the problem. But maybe it isn't too much of a problem because in the "first" mode, it still works. So maybe a bit of a lazy solution would be to add a note that single-key turbo mode simply does not work in cycle or close mode...
What do you think?
No worries, I'm sure you are super busy. Excited to see the new settings menu in full effect. I will work on a commit which allows us to "remember" the last open menu, and I think it would be fine for now to just note that it is not available for Single-Key Turbo mode. I think we should also default the "sameShortcutBehavior" setting to "first" to maintain the old behavior. Let me know what your thoughts are.
EDIT: I have completed the new commit.
I have just added this option to a new dropdown in the settings dialog. Yet I think we will need to put some more thought into storing the most recent request. Consider the case where the user uses like two sets of menus: Three menus are bound to shortcut A and three other menus are bound to shortcut B. Now we want to cycle through them independently and remember the last for both sets...
Ohh, this got closed as I merged the base branch :sweat_smile:. Could you reopen this against main?