kando-menu
Implement macOS's default 'show settings' hotkey
Description
Applications on Mac generally adopt a unified hotkey to show settings: Command + ,
It would be very welcome if this was integrated into Kando such that when Kando is up, pressing this hotkey would automatically open the Menu Editor.
Affected Desktop Environments
macOS
Additional Information
No response
Thanks for the suggestion! I guess that this should be possible. Only issue I see is that people would not be able to use this as a hotkey to open the menu then. But maybe that's OK :thinking:
Yeah I think that wouldn’t be an issue. Setting command-, as the Kando hot key would be ill-advised for Mac users anyway, as it’s already used systemwide, similar to command-s for save or command-q for quit
@Schneegans
I was about to commit something that addresses this but had to ask if you wanted a configuration option to enable or disable this behavior? I can't really think of a good name for it since its just for macOS and I am not sure if it should be in editor options or menu options. Maybe under menuOptions as useMacOsSettingsHotkey and default is true. I think menu options makes more sense as its not a toggle, it just opens the editor.
Well, I think it's fine to enable this universally. There are also Windows and Linux applications using it. Although, there you should listen for Ctrl+, instead of Command+,.
You could maybe make this on top of feature/separate-settings, as this will bring a lot of refactoring and else this could lead to some significant merge conflicts. In this branch, you also have a dedicated class for the open-settings button in the screen's corner. You can see here what the button does when clicked. You would need to do basically the same when the hotkey is pressed.