pennywise icon indicating copy to clipboard operation
pennywise copied to clipboard

Some icons are garbage

Open reini-1 opened this issue 5 years ago • 5 comments

Do you want to request a feature or report a bug? Bug

What is the current behavior? Hicolor icon 16x16, 32x32, 48x48 seems to bee garbage. They show some random pixels. The other sizes seems to be ok.

Expected behavior Propper icons in all sizes.

URL attempting to access

Screenshots (Optional But May Be Requested) image

image

Pennywise Version: pennywise 0.6.0 amd64

OS / OS Version: Distributor ID: Ubuntu Description: Ubuntu 18.10 Release: 18.10 Codename: cosmic

reini-1 avatar Nov 06 '18 11:11 reini-1

I think the noisy images are not included in the repo. So it's just showing noise

akash-joshi avatar Nov 09 '18 03:11 akash-joshi

The noisy ones are included as i have seen this icon pop up on my mac from time to time

The-Code-Monkey avatar Nov 09 '18 07:11 The-Code-Monkey

I think the noisy images are not included in the repo. So it's just showing noise

The broken files are in the debian package:

$ dpkg -L pennywise | grep png
/usr/share/icons/hicolor/96x96/apps/pennywise.png
/usr/share/icons/hicolor/16x16/apps/pennywise.png
/usr/share/icons/hicolor/64x64/apps/pennywise.png
/usr/share/icons/hicolor/32x32/apps/pennywise.png
/usr/share/icons/hicolor/24x24/apps/pennywise.png
/usr/share/icons/hicolor/128x128/apps/pennywise.png
/usr/share/icons/hicolor/256x256/apps/pennywise.png
/usr/share/icons/hicolor/48x48/apps/pennywise.png
/usr/share/icons/hicolor/512x512/apps/pennywise.png

and on the filesystem if pennywise*.deb package is installed:

$ ls -al /usr/share/icons/hicolor/*/apps/pennywise.png
-rw-r--r-- 1 root root  8906 Nov  9 18:54 /usr/share/icons/hicolor/128x128/apps/pennywise.png
-rw-r--r-- 1 root root   931 Nov  9 18:54 /usr/share/icons/hicolor/16x16/apps/pennywise.png
-rw-r--r-- 1 root root  1606 Nov  9 18:54 /usr/share/icons/hicolor/24x24/apps/pennywise.png
-rw-r--r-- 1 root root 19381 Nov  9 18:54 /usr/share/icons/hicolor/256x256/apps/pennywise.png
-rw-r--r-- 1 root root  2831 Nov  9 18:54 /usr/share/icons/hicolor/32x32/apps/pennywise.png
-rw-r--r-- 1 root root  6221 Nov  9 18:54 /usr/share/icons/hicolor/48x48/apps/pennywise.png
-rw-r--r-- 1 root root 44558 Nov  9 18:54 /usr/share/icons/hicolor/512x512/apps/pennywise.png
-rw-r--r-- 1 root root  5916 Nov  9 18:54 /usr/share/icons/hicolor/64x64/apps/pennywise.png
-rw-r--r-- 1 root root  9874 Nov  9 18:54 /usr/share/icons/hicolor/96x96/apps/pennywise.png

and as you can see in the screen shot from my first mail that there are some images broken. I don't know, how you build the debian package and where the images came from. Maybe you generate them from src/icons/pennywise.svg and there is something wrong with this. I created the broken images with gimp from 512x512 one and everything was fine.

reini-1 avatar Nov 14 '18 20:11 reini-1

showing as a garbage icon in my alfred too

ameeno avatar Nov 22 '18 16:11 ameeno

As a workaround I downloaded pennywise.svg and created the png files with image magick convert:

dpkg -L pennywise | sed -n 's|/usr/share/icons/hicolor/\([^/]\+\)/apps/pennywise.png|\1|p' | sudo xargs -n1 -I{} convert -background transparent -size {} pennywise.svg /usr/share/icons/hicolor/{}/apps/pennywise.png

reini-1 avatar Nov 23 '18 16:11 reini-1