git-standup icon indicating copy to clipboard operation
git-standup copied to clipboard

support git submodules

Open epcim opened this issue 7 years ago • 4 comments

if repo has submodules, the commits are not found

epcim avatar May 05 '17 07:05 epcim

https://github.com/randomize/git-standup/commit/5b3677fb4c0474c74d062db7088e17de60987988 Simplest possible solution to add 'git submodule foreach', but perhaps a more sophisticated one would be updating .git directory search algorithm so it doesn't ignore submodule dirs (they have .git as file instead of dir).

randomize avatar Aug 07 '18 10:08 randomize

Really excited to see this tool exists, bummed to learn it ignores submodules

jlewin avatar Mar 13 '19 20:03 jlewin

I found that commenting all these lines will show the commits from submodules: For a strange reason, this condition evaluates to TRUE and skips the submodule commits. You need to pass -F though. git standup -F -d 3 -m 2

# continue if not a git directory
#  if [[ ! -d ".git" || -f ".git" ]] ; then
#   cd ${BASE_DIR}
#    continue
#  fi

Later edit: I am on macOS Catalina, using GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin19)

mihaicris avatar Apr 05 '20 09:04 mihaicris

Issue still exists in master. Applying the patch in #116 seems to fix it for me. Were there some other issues with the PR that made you close it @mihaicris ?

ghost avatar Apr 30 '21 11:04 ghost