driver.js icon indicating copy to clipboard operation
driver.js copied to clipboard

aria-controls attribute removed during runtime.

Open Kashif-24 opened this issue 1 year ago • 3 comments

Issue Summary: The aria-controls attribute, which is set on certain elements in the HTML, is being unexpectedly removed during runtime when using the driver.js library for creating tours.

Steps to Reproduce:

  1. Set up a webpage with elements that have the aria-controls attribute defined.
  2. Initialize a tour using the driver.js library, targeting elements with aria-controls.
  3. Run the tour and observe that the aria-controls attribute is removed from the elements during runtime.

Expected Behavior: The aria-controls attribute should remain intact on the elements even after running the tour with driver.js.

Actual Behavior: The aria-controls attribute is removed from the elements during runtime, which can cause accessibility issues and unexpected behavior on the page.

Kashif-24 avatar May 10 '24 13:05 Kashif-24

https://github.com/kamranahmedse/driver.js/blob/9e6f1a45b3fb023886518a99cfcb3985275b9af0/src/highlight.ts#L171-L179

@Kashif-24

xionnon avatar May 11 '24 01:05 xionnon

thanks.

Kashif-24 avatar May 11 '24 06:05 Kashif-24

i test it but it is not working. @xionnon thanks.

Kashif-24 avatar May 11 '24 07:05 Kashif-24