joshuto icon indicating copy to clipboard operation
joshuto copied to clipboard

symlink not work on macos

Open awayme opened this issue 1 year ago • 1 comments

I recently started using Joshuto after switching from Ranger.py. Everything in Joshuto works like a charm, but I’m having an issue with creating symlinks.

Here’s what I’m doing:

•	Using Joshuto 0.9.8 with the default configuration pulled from the GitHub repo’s main branch (no changes made to the configs).
•	I press ‘yy’ on a file or directory, then navigate to a new directory and press ‘pL’ or ‘pl’.

However, nothing happens. No symlink is created and no error is reported.

Is there something I’m doing wrong, or is this a known issue?

Details:

•	Joshuto version: 0.9.8
•	Build time: 2024-03-15 23:53:29 +00:00
•	Build environment: rustc 1.76.0 (07dca489a 2024-02-04) (Homebrew)

•	System: macOS M1 / Sonoma 14.5

Thank you!

awayme avatar Jun 03 '24 11:06 awayme

Hey, I think theres some confusion here with the symlink ability.

It should be

  1. pl add selected files to clipboard
  2. pp paste them as symlink

Similar to how cut and copy works

cut: dd, pp copy yy, pp

kamiyaa avatar Jul 06 '24 23:07 kamiyaa

Thanks @kamiyaa, that helped me, too.

What I think is confusing here is the following:

  • In ranger, you
    1. yank a file via yy (same as for copying) and
    2. paste as symlink via pl (rather than paste a copy)
  • whereas in joshuto you
    1. yank as symlink pl (rather than yanking for copying) and
    2. paste via pp (same as for copying)

Seems like this was decided yere but without explicit consideration of these two approaches.

Not only does this cause the confusion because the "known" workflow for people coming from ranger doesn't appear to work (yy followed by pl has no effect), the keybinding also don't make a lot of sense to me (p stands for paste, but "adding selected files to clipboard" is not pasting, correct?).

It has been mentioned here that breaking changes are acceptable for improving UX, so I think changing this to the ranger-like approach is worth considering.

I'd love to hear your thoughts on this @kamiyaa. Should we create a separate issue (and close this)? Thank you!

flipsi avatar Oct 21 '24 10:10 flipsi

Interesting. I think the ranger approach makes more sense. Intuitively, users would yy and decide whether to paste, paste symlink or paste overwrite at a later state.

Lets create a separate issue for this :+1:

kamiyaa avatar Nov 03 '24 14:11 kamiyaa