joshuto icon indicating copy to clipboard operation
joshuto copied to clipboard

Add flake support

Open Ruixi-rebirth opened this issue 1 year ago • 4 comments

Format

  • *.sh is formatted by beautysh and has an indent size of 4 spaces
  • *.yaml, *.md formatted by prettier
  • *.toml is formatted by taplo
  • *.rs formatted by rustfmt

Add flake support

  • Provide development environment
  • Provision of all file types within the format project
  • Provides nixos with a way to install the git version of this package

https://github.com/kamiyaa/joshuto/assets/75824585/46bbe755-5404-4b20-95d0-b78966278e15

Ruixi-rebirth avatar May 23 '23 15:05 Ruixi-rebirth

@kamiyaa

Ruixi-rebirth avatar May 24 '23 02:05 Ruixi-rebirth

The style changes is all good, but does the NixOS Flake support have to be part of the main codebase?

I ask this because usually package files are stored and maintained by the OS repositories rather than the program. ie. pkgbuilds for arch, ebuilds for gentoo, rpm for fedora, deb for debian.

kamiyaa avatar May 27 '23 12:05 kamiyaa

Yes, it has to be part of the main codebase. Although nixos upstream has already been packaged, it makes the most sense for users to enable flake support for this repository in order to update it at the same time as this one

Ruixi-rebirth avatar May 27 '23 14:05 Ruixi-rebirth

There are also other repositories with flake support, these are examples: wayabr leftwm hyprland pianotrans ......

Ruixi-rebirth avatar May 27 '23 15:05 Ruixi-rebirth

Yes, it has to be part of the main codebase. Although nixos upstream has already been packaged, it makes the most sense for users to enable flake support for this repository in order to update it at the same time as this one

Got it!

kamiyaa avatar May 28 '23 02:05 kamiyaa