semaphore icon indicating copy to clipboard operation
semaphore copied to clipboard

goroutine leak

Open kamilsk opened this issue 7 years ago • 1 comments

  • [ ] https://github.com/kamilsk/semaphore/blob/master/channel.go#L42-L46
  • [ ] https://github.com/kamilsk/semaphore/blob/master/context.go#L11-L12
  • [ ] https://github.com/kamilsk/semaphore/blob/master/channel.go#L52-L63 - channel + cancel, because time.After is bad
  • [ ] https://github.com/kamilsk/semaphore/blob/master/channel.go#L35-L49 - the same as above, because we don't need to listen signal when work is done
  • [ ] investigate more

kamilsk avatar Jan 15 '18 12:01 kamilsk

https://go101.org/article/concurrent-common-mistakes.html

kamilsk avatar May 04 '18 09:05 kamilsk