Kamil Mysliwiec
Kamil Mysliwiec
I'll take a look as soon as I can
This is looking great so far @thekip, thank you! I left a few minor comments so far but I'll definitely pull all changes and walk through them more meticulously very...
> What is LN? 😅 I meant Linkedin! Apologies > Do nestjs still support typescript version prior 4.2? Where i can find a minimal system requirements? There should be "no...
> Well, for such things as a typescript transformation plugin we should define a "minimal version" because we a heavily relay on typescript compiler API which changes over time. So...
Would you be able to rebase your changes @thekip? If you're busy, I can look into this instead
I'd love to merge this PR but I feel like we're trying to bring too many features at once. If we could cherry-pick the following changes for now: 1. Support...
I went ahead and removed features that I've mentioned here https://github.com/nestjs/graphql/pull/1757#issuecomment-1228416518 Feel free to create separate PRs with those individual features 🙌 Fantastic PR, thanks for your contribution!
@EdouardBougon could you create a new issue with a minimum reproduction repository?
@EdouardBougon this line likely causes this issue https://github.com/nestjs/graphql/blob/master/packages/graphql/lib/plugin/visitors/model-class.visitor.ts#L33 Can you modify this array locally (adding ArgsType) and check if it fixes your issue?
Please provide a **minimum reproduction repository**. The one you shared contains several resolvers and has a dependency on your GH repositories.